> On June 27, 2019, 10:20 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 4879-4880 (patched) > > <https://reviews.apache.org/r/70959/diff/1/?file=2152405#file2152405line4879> > > > > I'm not sure, but will any frameworks exist on the agent once all tasks > > are terminal and ACKed? I'm wondering if we can just check whether or not > > `frameworks` is empty to determine if all tasks are gone?
This is exactly the point where all tasks could be ack'ed, but frameworks might still not be `idle` so `frameworks` wouldn't be empty. Do we care about including whether there are still executors running on the agent when checking whether we are done or not? In the former case we'd need to perform this check elsewhere. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70959/#review216181 ----------------------------------------------------------- On June 27, 2019, 5:24 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70959/ > ----------------------------------------------------------- > > (Updated June 27, 2019, 5:24 p.m.) > > > Review request for mesos, Greg Mann and Joseph Wu. > > > Bugs: MESOS-9860 > https://issues.apache.org/jira/browse/MESOS-9860 > > > Repository: mesos > > > Description > ------- > > Once a draining agent has neither frameworks with pending tasks nor any > executors with either queued or launched tasks it has finished draining. > This patch adds handling of that case which clears both the in-memory > and persisted drain configuration. > > > Diffs > ----- > > src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41 > src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e > > > Diff: https://reviews.apache.org/r/70959/diff/2/ > > > Testing > ------- > > `make check` > > tested as part of https://reviews.apache.org/r/70960/ > > > Thanks, > > Benjamin Bannier > >
