> On June 27, 2019, 10:17 p.m., Vinod Kone wrote: > > src/slave/slave.cpp > > Lines 4876 (patched) > > <https://reviews.apache.org/r/70959/diff/2/?file=2152613#file2152613line4876> > > > > there are several places in this file where `removeFramework` is > > called, why is this only being called here? i think it would be less error > > prone and future proof to call this from within `removeFramework()` ?
I have moved this into `removeFramework` and similar moved the operation-related trigger to `removeOperation`. > On June 27, 2019, 10:17 p.m., Vinod Kone wrote: > > src/slave/slave.cpp > > Lines 9791-9801 (patched) > > <https://reviews.apache.org/r/70959/diff/2/?file=2152613#file2152613line9791> > > > > can this be replaced with `return framework->idle()`? This was not have been possible with the function being called from the status update continuations since in that case executors would only have been removed once the containerizer had finished waiting for it. Now that this is invoked during framework (or operation) removal the executors are gone, and this works. Fixed. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70959/#review216201 ----------------------------------------------------------- On June 28, 2019, 1:11 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70959/ > ----------------------------------------------------------- > > (Updated June 28, 2019, 1:11 a.m.) > > > Review request for mesos, Greg Mann and Joseph Wu. > > > Bugs: MESOS-9860 > https://issues.apache.org/jira/browse/MESOS-9860 > > > Repository: mesos > > > Description > ------- > > Once a draining agent has neither frameworks with pending tasks nor any > executors with either queued or launched tasks it has finished draining. > This patch adds handling of that case which clears both the in-memory > and persisted drain configuration. > > > Diffs > ----- > > src/slave/slave.hpp 6954f53ff1531b9fcb688ef76acddf6a3d849a41 > src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e > > > Diff: https://reviews.apache.org/r/70959/diff/3/ > > > Testing > ------- > > `make check` > > tested as part of https://reviews.apache.org/r/70960/ > > > Thanks, > > Benjamin Bannier > >
