----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72216/#review219855 -----------------------------------------------------------
src/master/validation.cpp Lines 1567 (patched) <https://reviews.apache.org/r/72216/#comment308101> Can a client set a limit for one parameter only (e.g., "cpus")? src/master/validation.cpp Lines 1583 (patched) <https://reviews.apache.org/r/72216/#comment308100> Consider using `Bytes::MEGABYTES` instead of `(1024 * 1024)` src/master/validation.cpp Lines 1991 (patched) <https://reviews.apache.org/r/72216/#comment308102> `shareCgroups` can be initialized with the value taken from the first task within a task group. This may simplify the `foreach` loop. Also, this would allow us to move `if (currentShareCgroups && !task.limits().empty` check outside the loop. - Andrei Budnik On Март 9, 2020, 3:25 п.п., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72216/ > ----------------------------------------------------------- > > (Updated Март 9, 2020, 3:25 п.п.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10045 > https://issues.apache.org/jira/browse/MESOS-10045 > > > Repository: mesos > > > Description > ------- > > Added master validation for task resource limits and shared cgroups. > > > Diffs > ----- > > src/master/validation.cpp 084f281eadd65cb8ae0a19b7b7797dc71ccebdd2 > > > Diff: https://reviews.apache.org/r/72216/diff/1/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
