> On March 10, 2020, 1:06 p.m., Andrei Budnik wrote: > > src/master/validation.cpp > > Lines 1567 (patched) > > <https://reviews.apache.org/r/72216/diff/3/?file=2213343#file2213343line1567> > > > > `if (limits.size() > cpuCount + memCount)` might be slightly easier to > > understand.
Good call; done. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72216/#review219868 ----------------------------------------------------------- On March 11, 2020, 7:10 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72216/ > ----------------------------------------------------------- > > (Updated March 11, 2020, 7:10 p.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10045 > https://issues.apache.org/jira/browse/MESOS-10045 > > > Repository: mesos > > > Description > ------- > > Added master validation for task resource limits and shared cgroups. > > > Diffs > ----- > > src/master/validation.cpp 084f281eadd65cb8ae0a19b7b7797dc71ccebdd2 > > > Diff: https://reviews.apache.org/r/72216/diff/4/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
