----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72216/#review219868 -----------------------------------------------------------
Fix it, then Ship it! Ship It! src/master/validation.cpp Lines 1567 (patched) <https://reviews.apache.org/r/72216/#comment308115> `if (limits.size() > cpuCount + memCount)` might be slightly easier to understand. src/master/validation.cpp Lines 1999 (patched) <https://reviews.apache.org/r/72216/#comment308114> Let's declarate `shareCgroups` variable right before the `foreach` loop. The comment above can be updated as we no longer compare values of `share_cgroups` field between executor container and its task containers. - Andrei Budnik On Март 10, 2020, 9:42 д.п., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72216/ > ----------------------------------------------------------- > > (Updated Март 10, 2020, 9:42 д.п.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10045 > https://issues.apache.org/jira/browse/MESOS-10045 > > > Repository: mesos > > > Description > ------- > > Added master validation for task resource limits and shared cgroups. > > > Diffs > ----- > > src/master/validation.cpp 084f281eadd65cb8ae0a19b7b7797dc71ccebdd2 > > > Diff: https://reviews.apache.org/r/72216/diff/3/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
