cloud-fan commented on a change in pull request #26995: [SPARK-30341][SQL] Overflow check for interval arithmetic operations URL: https://github.com/apache/spark/pull/26995#discussion_r362054179
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/intervalExpressions.scala ########## @@ -110,50 +110,57 @@ object ExtractIntervalPart { } } -abstract class IntervalNumOperation( - interval: Expression, - num: Expression, - operation: (CalendarInterval, Double) => CalendarInterval, - operationName: String) +abstract class IntervalNumOperation(interval: Expression, num: Expression, operationName: String) extends BinaryExpression with ImplicitCastInputTypes with Serializable { + + protected val methodStr: String = + IntervalUtils.getClass.getName.stripSuffix("$") + "." + operationName + "Exact" + override def left: Expression = interval override def right: Expression = num override def inputTypes: Seq[AbstractDataType] = Seq(CalendarIntervalType, DoubleType) + override def dataType: DataType = CalendarIntervalType override def nullable: Boolean = true + override def prettyName: String = operationName + "_interval" +} + +case class MultiplyInterval(interval: Expression, num: Expression) Review comment: is this also new in Spark 3.0? If it is I think it's OK to always follow the ansi behavior regardless the ansi flag. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org