cloud-fan commented on a change in pull request #26995: [SPARK-30341][SQL]
Overflow check for interval arithmetic operations
URL: https://github.com/apache/spark/pull/26995#discussion_r362401180
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala
##########
@@ -81,7 +80,8 @@ case class Average(child: Expression) extends
DeclarativeAggregate with Implicit
case _: DecimalType =>
DecimalPrecision.decimalAndDecimal(sum /
count.cast(DecimalType.LongDecimal)).cast(resultType)
case CalendarIntervalType =>
- DivideInterval(sum.cast(resultType), count.cast(DoubleType))
+ val newCount = If(EqualTo(count, Literal(0L)), Literal(null, LongType),
count)
Review comment:
I checked pgsql, avg on empty table returns null. So this is corrected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
