cloud-fan commented on a change in pull request #26995: [SPARK-30341][SQL]
Overflow check for interval arithmetic operations
URL: https://github.com/apache/spark/pull/26995#discussion_r362365706
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -416,13 +418,36 @@ object IntervalUtils {
/**
* Unary minus, return the negated the calendar interval value.
*
- * @param interval the interval to be negated
- * @return a new calendar interval instance with all it parameters negated
from the origin one.
+ * @throws ArithmeticException if the result overflows any field value
+ */
+ def negateExact(interval: CalendarInterval): CalendarInterval = {
+ val months = Math.negateExact(interval.months)
+ val days = Math.negateExact(interval.days)
+ val microseconds = Math.negateExact(interval.microseconds)
+ new CalendarInterval(months, days, microseconds)
+ }
+
+ /**
+ * Unary minus, return the negated the calendar interval value.
+ *
Review comment:
unnecessary blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
