srowen commented on a change in pull request #27174: [SPARK-30490][SQL] Eliminate compiler warnings in Avro datasource URL: https://github.com/apache/spark/pull/27174#discussion_r365527305
########## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala ########## @@ -68,8 +68,10 @@ class AvroOptions( * If the option is not set, the Hadoop's config `avro.mapred.ignore.inputs.without.extension` * is taken into account. If the former one is not set too, file extensions are ignored. */ - @deprecated("Use the general data source option pathGlobFilter for filtering file names", "3.0") Review comment: Why remove this if it's really deprecated? I get that it will remove some compiler warnings, but, that's not super important, or can be worked around as you do elsewhere by deprecating the test methods too? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org