HyukjinKwon commented on a change in pull request #27174: [SPARK-30490][SQL] Eliminate compiler warnings in Avro datasource URL: https://github.com/apache/spark/pull/27174#discussion_r365571997
########## File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala ########## @@ -78,7 +80,17 @@ class AvroOptions( parameters .get(AvroOptions.ignoreExtensionKey) .map(_.toBoolean) - .getOrElse(!ignoreFilesWithoutExtension) + .map { ignoreExtensionOption => + if (ignoreExtensionOption != !ignoreFilesWithoutExtensionByDefault) { + warn(s"The Avro option '${AvroOptions.ignoreExtensionKey}'") Review comment: @MaxGekk, from a cursory look, this warning can be shown for every file which I think is noisy: https://github.com/apache/spark/blob/053dd858d38e6107bc71e0aa3a4954291b74f8c8/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FilePartitionReaderFactory.scala#L24-L30 https://github.com/apache/spark/blob/053dd858d38e6107bc71e0aa3a4954291b74f8c8/external/avro/src/main/scala/org/apache/spark/sql/v2/avro/AvroPartitionReaderFactory.scala#L61 Do you mind if I ask double check this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org