MaxGekk commented on issue #27174: [SPARK-30490][SQL] Eliminate compiler warnings in Avro datasource URL: https://github.com/apache/spark/pull/27174#issuecomment-573331430 AvroOptions (and other options like CSVOptions) shouldn’t be accessible to users. Deprecating any values inside of AvroOptions seems similar to deprecating config entries inside of SQLConf - the values are not visible to users, and they are not aware of compiler warnings. сб, 11 янв. 2020 г. в 19:12, Sean Owen <notificati...@github.com>: > OK, the class appears public though, it's definitely not meant to be > accessed for other reasons? > > On Sat, Jan 11, 2020 at 10:05 AM Maxim Gekk <notificati...@github.com> > wrote: > > > Sean, deprecating of the value doesn’t make any sense because it is not > > used by users. > > > > сб, 11 янв. 2020 г. в 18:32, Sean Owen <notificati...@github.com>: > > > > > *@srowen* commented on this pull request. > > > ------------------------------ > > > > > > In > > > > external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala > > > <https://github.com/apache/spark/pull/27174#discussion_r365527305>: > > > > > > > @@ -68,8 +68,10 @@ class AvroOptions( > > > * If the option is not set, the Hadoop's config > > `avro.mapred.ignore.inputs.without.extension` > > > * is taken into account. If the former one is not set too, file > > extensions are ignored. > > > */ > > > - @deprecated("Use the general data source option pathGlobFilter for > > filtering file names", "3.0") > > > > > > Why remove this if it's really deprecated? I get that it will remove > some > > > compiler warnings, but, that's not super important, or can be worked > > around > > > as you do elsewhere by deprecating the test methods too? > > > > > > — > > > You are receiving this because you authored the thread. > > > > > > > > > Reply to this email directly, view it on GitHub > > > < > > > https://github.com/apache/spark/pull/27174?email_source=notifications&email_token=AAMB5GPBEQSPURU7DY5UBZDQ5HRBJA5CNFSM4KFRXRNKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRNUYHY#pullrequestreview-341527583 > > >, > > > or unsubscribe > > > < > > > https://github.com/notifications/unsubscribe-auth/AAMB5GNSMNGO5AHKJSOU23TQ5HRBJANCNFSM4KFRXRNA > > > > > > . > > > > > -- > > Yours faithfully, > > Maxim Gekk > > http://www.linkedin.com/in/maxgekk > > > > — > > You are receiving this because you commented. > > Reply to this email directly, view it on GitHub > > < > https://github.com/apache/spark/pull/27174?email_source=notifications&email_token=AAGIZ6XYLIVBDX76OZ3FBDTQ5HU5LA5CNFSM4KFRXRNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWFBPY#issuecomment-573329599 > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AAGIZ6TVE5OHMOWBX7XPJH3Q5HU5LANCNFSM4KFRXRNA > > > > . > > > > — > You are receiving this because you authored the thread. > > > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/27174?email_source=notifications&email_token=AAMB5GJCMNKRPTQPXJKWI2TQ5HVXZA5CNFSM4KFRXRNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIWFGBA#issuecomment-573330180>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAMB5GJAQT423WCLQBWXY6LQ5HVXZANCNFSM4KFRXRNA> > . > -- Yours faithfully, Maxim Gekk http://www.linkedin.com/in/maxgekk
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
