maropu commented on a change in pull request #28647:
URL: https://github.com/apache/spark/pull/28647#discussion_r432793971
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -2720,4 +2704,26 @@ class HiveDDLSuite
checkAnswer(sql("SHOW PARTITIONS ta_part"), Row("ts=10") :: Nil)
}
}
+
+ test("SPARK-31828: Retain table properties at CreateTableLikeCommand") {
+ val catalog = spark.sessionState.catalog
+ withTable("t1", "t2", "t3") {
+ sql(s"CREATE TABLE t1(c1 int) TBLPROPERTIES('k1'='v1', 'k2'='v2',
'totalNumberFiles'='meta')")
Review comment:
Just in case, could you test all the prpos in
`METASTORE_GENERATED_PROPERTIES`? Probably, its beetter to split it into two
test units like add a new test unit `test("SPARK-31828: Filters out Hive
metastore properties in CreateTableLikeCommand") {`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
