[GitHub] [spark] maropu commented on a change in pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

[GitBox]

maropu commented on a change in pull request #28647:
URL: https://github.com/apache/spark/pull/28647#discussion_r432794744



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -115,6 +116,15 @@ case class CreateTableLikeCommand(
       CatalogTableType.EXTERNAL
     }
 
+    val newProperties = sourceTableDesc.tableType match {
+      case VIEW =>
+        // For view, we just use new properties
+        properties

Review comment:
       nit format;
   ```
   
       val newProperties = sourceTableDesc.tableType match {
         case MANAGED | EXTERNAL =>
           // Hive only retain the useful properties through serde class 
annotation.
           // For better compatible with Hive, we remove the metastore 
properties.
           sourceTableDesc.properties -- 
DDLUtils.METASTORE_GENERATED_PROPERTIES ++ properties
   
         case VIEW =>
           // For view, we just use new properties
           properties
       }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org