cloud-fan commented on a change in pull request #28728:
URL: https://github.com/apache/spark/pull/28728#discussion_r435324570
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -234,22 +234,22 @@ private object DateTimeFormatterHelper {
val formatter = DateTimeFormatter.ofPattern("LLL qqq", Locale.US)
formatter.format(LocalDate.of(2000, 1, 1)) == "1 1"
}
- final val unsupportedLetters = Set('A', 'c', 'e', 'n', 'N', 'p')
+ final val unsupportedLetters = Set('A', 'c', 'n', 'N', 'p', 'Y', 'W', 'w',
'u')
Review comment:
how about we add a new list `weekBasedLetters`? They deserve a dedicated
error message, to suggest users using the SQL function `EXTRACT`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
