cloud-fan commented on a change in pull request #28728:
URL: https://github.com/apache/spark/pull/28728#discussion_r435325539
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateFormatterSuite.scala
##########
@@ -199,4 +197,8 @@ class DateFormatterSuite extends SparkFunSuite with
SQLHelper {
// SparkUpgradeException here.
intercept[SparkUpgradeException](formatter.parse("02-29"))
}
+
+ override def checkFormatterCreation(pattern: String, isParsing: Boolean):
Unit = {
Review comment:
can we move it to the beginning of this class? to avoid code conflict
when we add new tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
