cloud-fan commented on a change in pull request #28728:
URL: https://github.com/apache/spark/pull/28728#discussion_r435325729
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TimestampFormatterSuite.scala
##########
@@ -418,15 +417,7 @@ class TimestampFormatterSuite extends SparkFunSuite with
SQLHelper with Matchers
assert(t5 === date(1970))
}
- test("explicitly forbidden datetime patterns") {
- // not support by the legacy one too
- Seq("QQQQQ", "qqqqq", "A", "c", "e", "n", "N", "p").foreach { pattern =>
- intercept[IllegalArgumentException](TimestampFormatter(pattern,
UTC).format(0))
- }
- // supported by the legacy one, then we will suggest users with
SparkUpgradeException
- Seq("GGGGG", "MMMMM", "LLLLL", "EEEEE", "uuuuu", "aa", "aaa", "y" * 11,
"y" * 11)
- .foreach { pattern =>
- intercept[SparkUpgradeException](TimestampFormatter(pattern,
UTC).format(0))
- }
+ override def checkFormatterCreation(pattern: String, isParsing: Boolean):
Unit = {
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
