holdenk commented on a change in pull request #28864: URL: https://github.com/apache/spark/pull/28864#discussion_r442917016
########## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ########## @@ -226,9 +226,9 @@ private[spark] class BlockManager( private val maxFailuresBeforeLocationRefresh = conf.get(config.BLOCK_FAILURES_BEFORE_LOCATION_REFRESH) - private val slaveEndpoint = rpcEnv.setupEndpoint( + private val replicaEndpoint = rpcEnv.setupEndpoint( Review comment: Yeah the goal was primary/replica. We could go with “Storage” instead if you think that would be better? Since those endpoints are responsible for storing the blocks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org