rdblue commented on a change in pull request #28864:
URL: https://github.com/apache/spark/pull/28864#discussion_r443031936
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -226,9 +226,9 @@ private[spark] class BlockManager(
private val maxFailuresBeforeLocationRefresh =
conf.get(config.BLOCK_FAILURES_BEFORE_LOCATION_REFRESH)
- private val slaveEndpoint = rpcEnv.setupEndpoint(
+ private val replicaEndpoint = rpcEnv.setupEndpoint(
Review comment:
I like "storageEndpoint". I think that's probably more accurate than
replica since we don't necessarily replicate blocks, and this is the endpoint
for the primary as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
