msamirkhan commented on a change in pull request #29354:
URL: https://github.com/apache/spark/pull/29354#discussion_r465995487
##########
File path:
external/avro/src/main/scala/org/apache/spark/sql/avro/SparkAvroDatumReader.scala
##########
@@ -420,10 +426,27 @@ class SparkAvroDatumReader[T](
structReader(rowUpdater, in)
updater.set(ordinal, row)
} else {
- (updater, ordinal, in) =>
- val row = createRow()
- structReader(new RowUpdater(row), in)
+ val rowPool = ArrayBuffer.empty[InternalRow]
+ val rowUpdaterPool = ArrayBuffer.empty[RowUpdater]
+ val i = reuseIndices.length
+ reuseIndices += 0
+
Review comment:
These changes did not result in any improvements so were removed later
on. Read times are in column F on pg 2 of the benchmark pdf attached to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
