msamirkhan commented on a change in pull request #29354:
URL: https://github.com/apache/spark/pull/29354#discussion_r466001347
##########
File path:
external/avro/src/main/scala/org/apache/spark/sql/avro/SparkAvroDatumReader.scala
##########
@@ -421,12 +418,10 @@ class SparkAvroDatumReader[T](
path: List[String]
): (CatalystDataUpdater, Int, ResolvingDecoder) => Unit = {
val elementReader = newReader(avroType.getElementType, elementType, path,
false)
- val arrayCreator = getArrayDataCreator(elementType)
- val arrayExpander = getArrayDataExpander(elementType)
(updater, ordinal, in) => {
var length = in.readArrayStart()
- var array = arrayCreator(length)
+ var array = createArrayData(elementType, length)
Review comment:
Simplifying array data creation
https://github.com/apache/spark/pull/29354/commits/b1d677ba7f24e1f756b1c3af6f49e463b1dd94ff#r466000797
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
