msamirkhan commented on a change in pull request #29354:
URL: https://github.com/apache/spark/pull/29354#discussion_r466004477
##########
File path:
external/avro/src/main/scala/org/apache/spark/sql/avro/SparkAvroDatumWriter.scala
##########
@@ -125,42 +125,42 @@ class SparkAvroDatumWriter[D](rootAvroType: Schema,
rootCatalystType: DataType,
catalystType: DataType, avroType: Schema, path: List[String]
): Writer = {
val baseWriter: Writer = (catalystType, avroType.getType) match {
- case (NullType, NULL) => getNullWriter(avroType)
- case (BooleanType, BOOLEAN) => getBooleanWriter(avroType)
- case (ByteType, INT) => getByteAsIntWriter(avroType)
- case (ShortType, INT) => getShortAsIntWriter(avroType)
- case (IntegerType, INT) => getIntWriter(avroType)
- case (LongType, LONG) => getLongWriter(avroType)
- case (FloatType, FLOAT) => getFloatWriter(avroType)
- case (DoubleType, DOUBLE) => getDoubleWriter(avroType)
+ case (NullType, NULL) => makeNullWriter(avroType)
+ case (BooleanType, BOOLEAN) => makeBooleanWriter(avroType)
+ case (ByteType, INT) => makeByteAsIntWriter(avroType)
+ case (ShortType, INT) => makeShortAsIntWriter(avroType)
+ case (IntegerType, INT) => makeIntWriter(avroType)
+ case (LongType, LONG) => makeLongWriter(avroType)
+ case (FloatType, FLOAT) => makeFloatWriter(avroType)
+ case (DoubleType, DOUBLE) => makeDoubleWriter(avroType)
Review comment:
Changing names of methods from getXYZWriter to makeXYZWriter since that
better reflects the methods. Just name change so no entry in
https://github.com/apache/spark/files/5025167/AvroBenchmarks.pdf
##########
File path:
external/avro/src/main/scala/org/apache/spark/sql/avro/SparkAvroDatumWriter.scala
##########
@@ -125,42 +125,42 @@ class SparkAvroDatumWriter[D](rootAvroType: Schema,
rootCatalystType: DataType,
catalystType: DataType, avroType: Schema, path: List[String]
): Writer = {
val baseWriter: Writer = (catalystType, avroType.getType) match {
- case (NullType, NULL) => getNullWriter(avroType)
- case (BooleanType, BOOLEAN) => getBooleanWriter(avroType)
- case (ByteType, INT) => getByteAsIntWriter(avroType)
- case (ShortType, INT) => getShortAsIntWriter(avroType)
- case (IntegerType, INT) => getIntWriter(avroType)
- case (LongType, LONG) => getLongWriter(avroType)
- case (FloatType, FLOAT) => getFloatWriter(avroType)
- case (DoubleType, DOUBLE) => getDoubleWriter(avroType)
+ case (NullType, NULL) => makeNullWriter(avroType)
+ case (BooleanType, BOOLEAN) => makeBooleanWriter(avroType)
+ case (ByteType, INT) => makeByteAsIntWriter(avroType)
+ case (ShortType, INT) => makeShortAsIntWriter(avroType)
+ case (IntegerType, INT) => makeIntWriter(avroType)
+ case (LongType, LONG) => makeLongWriter(avroType)
+ case (FloatType, FLOAT) => makeFloatWriter(avroType)
+ case (DoubleType, DOUBLE) => makeDoubleWriter(avroType)
Review comment:
Changing names of methods from getXYZWriter to makeXYZWriter since that
better reflects the methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
