cloud-fan commented on a change in pull request #30154:
URL: https://github.com/apache/spark/pull/30154#discussion_r514035984
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala
##########
@@ -123,8 +123,14 @@ class JDBCTableCatalog extends TableCatalog with Logging {
"ignored: " + properties.asScala.map { case (k, v) => s"$k=$v"
}.mkString("[", ", ", "]"))
Review comment:
I think a more reasonable behavior is to fail if unsupported table
properties are given. JDBC V2 is new in this release so we still have a chance
to change it.
For these 4 builtin properties, I think we only need to support `comment`.
We should ignore `provider` for now. And after the CRETE TABLE unification, we
can force users to not specify `USING` when creating table in JDBC v2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
