cloud-fan commented on a change in pull request #30154: URL: https://github.com/apache/spark/pull/30154#discussion_r517837665
########## File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/V2JDBCTest.scala ########## @@ -146,5 +158,25 @@ private[v2] trait V2JDBCTest extends SharedSparkSession { }.getMessage assert(msg.contains("Table not found")) } + + test("CREATE TABLE with table comment") { + withTable(s"$catalogName.new_table") { + val logAppender = new LogAppender("table comment") + withLogAppender(logAppender) { + sql(s"CREATE TABLE $catalogName.new_table(i INT) USING _ COMMENT 'this is a comment'") + } + val createCommentWarning = logAppender.loggingEvents + .filter(_.getLevel == Level.WARN) + .map(_.getRenderedMessage) + .exists(_.contains("Cannot create JDBC table comment")) Review comment: No DB supports it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org