cloud-fan commented on a change in pull request #30154:
URL: https://github.com/apache/spark/pull/30154#discussion_r517836327
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -863,15 +863,24 @@ object JdbcUtils extends Logging {
schema: StructType,
caseSensitive: Boolean,
options: JdbcOptionsInWrite): Unit = {
+ val dialect = JdbcDialects.get(options.url)
val strSchema = schemaString(
schema, caseSensitive, options.url, options.createTableColumnTypes)
val createTableOptions = options.createTableOptions
// Create the table if the table does not exist.
// To allow certain options to append when create a new table, which can be
// table_options or partition_options.
// E.g., "CREATE TABLE t (name string) ENGINE=InnoDB DEFAULT CHARSET=utf8"
- val sql = s"CREATE TABLE $tableName ($strSchema) $createTableOptions"
- executeStatement(conn, options, sql)
+ val sql = dialect.createTable(tableName, strSchema, createTableOptions,
options.tableComment)
Review comment:
Now I agree that comment is just a special case. Can we revert it to the
previous version that we explicitly run an extra statement to set table comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
