holdenk commented on a change in pull request #31249:
URL: https://github.com/apache/spark/pull/31249#discussion_r565539349
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##########
@@ -506,6 +521,20 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
}
}
+ conf.get(EXECUTOR_DECOMMISSION_CLEANUP_INTERVAL).map { cleanupInterval =>
+ val cleanupTask = new Runnable() {
+ override def run(): Unit = Utils.tryLogNonFatalError {
+ val stragglers =
executorsToDecommission.filter(executorsPendingDecommission.contains(_))
Review comment:
Good catch on the thread safety
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
