holdenk commented on a change in pull request #31249:
URL: https://github.com/apache/spark/pull/31249#discussion_r565542013
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala
##########
@@ -345,8 +345,11 @@ class KubernetesSuite extends SparkFunSuite
}
// Delete the pod to simulate cluster scale down/migration.
// This will allow the pod to remain up for the grace period
+ // We set an intentionally long grace period to test that Spark
+ // exits once the blocks are done migrating and doesn't wait
for the
+ // entire grace period if it does not need to.
kubernetesTestComponents.kubernetesClient.pods()
- .withName(name).delete()
+ .withName(name).withGracePeriod(8640000).delete()
Review comment:
Sounds good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
