holdenk commented on a change in pull request #31249:
URL: https://github.com/apache/spark/pull/31249#discussion_r565606020
##########
File path:
core/src/test/scala/org/apache/spark/scheduler/HealthTrackerSuite.scala
##########
@@ -554,6 +554,51 @@ class HealthTrackerSuite extends SparkFunSuite with
BeforeAndAfterEach with Mock
verify(allocationClientMock).killExecutorsOnHost("hostA")
}
+ test("excluding decommission and kills executors when enabled") {
+ val allocationClientMock = mock[ExecutorAllocationClient]
+ healthTracker = new HealthTracker(listenerBusMock, conf,
Some(allocationClientMock), clock)
+
+ // verify we decommission when configured
+ conf.set(config.EXCLUDE_ON_FAILURE_KILL_ENABLED, true)
+ conf.set(config.DECOMMISSION_ENABLED.key, "true")
Review comment:
Without decommissioning enabled the executor _could_ do something
different (although right now your right this is not needed). It just seemed
like a better future proof configuration to have it on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
