dongjoon-hyun commented on a change in pull request #31835: URL: https://github.com/apache/spark/pull/31835#discussion_r595437096
########## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceNullWithFalseInPredicateSuite.scala ########## @@ -456,15 +456,21 @@ class ReplaceNullWithFalseInPredicateSuite extends PlanTest { private def testMerge(originalCond: Expression, expectedCond: Expression): Unit = { val func = (rel: LogicalPlan, expr: Expression) => { + val target = rel.as("target") + val source = rel.as("source") val assignments = Seq( - Assignment('i, 'i), - Assignment('b, 'b), - Assignment('a, 'a), - Assignment('m, 'm) + Assignment(UnresolvedAttribute("i"), UnresolvedAttribute("source.i")), + Assignment(UnresolvedAttribute("b"), UnresolvedAttribute("source.b")), + Assignment(UnresolvedAttribute("a"), UnresolvedAttribute("source.a")), + Assignment(UnresolvedAttribute("m"), UnresolvedAttribute("source.m")) Review comment: A question related to the above discussion, all of these work before and after this PR? Or, is this different test coverage? > For UPDATE SET a = source.a, I think it works before and after this fix. @Ngone51 can you confirm? > Yes, it works before and after this fix. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org