aokolnychyi commented on a change in pull request #31835:
URL: https://github.com/apache/spark/pull/31835#discussion_r595540393
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
##########
@@ -671,6 +671,19 @@ class AnalysisSuite extends AnalysisTest with Matchers {
Project(Seq(UnresolvedAttribute("temp0.a"),
UnresolvedAttribute("temp1.a")), join))
}
+ test("SPARK-34741: Avoid ambiguous reference in MergeIntoTable") {
+ val cond = 'a > 1
+ assertAnalysisError(
Review comment:
One more quick question, @cloud-fan. I thought the current construction
logic for `DataSourceV2Relation` would always produce different expr IDs for
output attributes:
```
DataSourceV2Relation(table, schema.toAttributes, catalog, identifier,
options)
```
I did not look closely. Is my assumption wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
