Ngone51 commented on a change in pull request #31835:
URL: https://github.com/apache/spark/pull/31835#discussion_r595727193
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceNullWithFalseInPredicateSuite.scala
##########
@@ -456,15 +456,21 @@ class ReplaceNullWithFalseInPredicateSuite extends
PlanTest {
private def testMerge(originalCond: Expression, expectedCond: Expression):
Unit = {
val func = (rel: LogicalPlan, expr: Expression) => {
+ val target = rel.as("target")
+ val source = rel.as("source")
val assignments = Seq(
- Assignment('i, 'i),
- Assignment('b, 'b),
- Assignment('a, 'a),
- Assignment('m, 'm)
+ Assignment(UnresolvedAttribute("i"), UnresolvedAttribute("source.i")),
+ Assignment(UnresolvedAttribute("b"), UnresolvedAttribute("source.b")),
+ Assignment(UnresolvedAttribute("a"), UnresolvedAttribute("source.a")),
+ Assignment(UnresolvedAttribute("m"), UnresolvedAttribute("source.m"))
Review comment:
Yes, it works both before and after. (Not different test coverage). But
these changes are required after we introduced `dedup` to `MergeIntoTable` in
this PR. Otherwise, tests can fail with the ambiguous reference error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
