cloud-fan commented on a change in pull request #32082:
URL: https://github.com/apache/spark/pull/32082#discussion_r621206480
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/functions/AggregateFunction.java
##########
@@ -25,12 +25,9 @@
/**
* Interface for a function that produces a result value by aggregating over
multiple input rows.
* <p>
- * For each input row, Spark will call an update method that corresponds to the
- * {@link #inputTypes() input data types}. The expected JVM argument types
must be the types used by
- * Spark's InternalRow API. If no direct method is found or when not using
codegen, Spark will call
- * update with {@link InternalRow}.
- * <p>
- * The JVM type of result values produced by this function must be the type
used by Spark's
+ * For each input row, Spark will call the {@link #update} method which should
evaluate the row
+ * and update the aggregation state. The JVM type of result values produced by
+ * {@link #produceResult} must be the type used by Spark's
* InternalRow API for the {@link DataType SQL data type} returned by {@link
#resultType()}.
Review comment:
shall we reference the classdoc of `ScalarFunction` for the type mapping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
