cloud-fan commented on a change in pull request #32082:
URL: https://github.com/apache/spark/pull/32082#discussion_r621211590
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1958,18 +1961,23 @@ class Analyzer(override val catalogManager:
CatalogManager)
override def apply(plan: LogicalPlan): LogicalPlan = {
val externalFunctionNameSet = new mutable.HashSet[FunctionIdentifier]()
plan.resolveExpressions {
- case f: UnresolvedFunction
- if externalFunctionNameSet.contains(normalizeFuncName(f.name)) => f
- case f: UnresolvedFunction if
v1SessionCatalog.isRegisteredFunction(f.name) => f
- case f: UnresolvedFunction if
v1SessionCatalog.isPersistentFunction(f.name) =>
- externalFunctionNameSet.add(normalizeFuncName(f.name))
- f
- case f: UnresolvedFunction =>
- withPosition(f) {
- throw new NoSuchFunctionException(
- f.name.database.getOrElse(v1SessionCatalog.getCurrentDatabase),
- f.name.funcName)
+ case f @ UnresolvedFunction(AsFunctionIdentifier(ident), _, _, _, _) =>
+ if (externalFunctionNameSet.contains(normalizeFuncName(ident)) ||
+ v1SessionCatalog.isRegisteredFunction(ident)) {
+ f
+ } else if (v1SessionCatalog.isPersistentFunction(ident)) {
+ externalFunctionNameSet.add(normalizeFuncName(ident))
+ f
+ } else {
+ withPosition(f) {
+ throw new NoSuchFunctionException(
+ ident.database.getOrElse(v1SessionCatalog.getCurrentDatabase),
+ ident.funcName)
+ }
}
+ case f: UnresolvedFunction =>
Review comment:
We are inside `resolveExpressions`. We can remove this case if we do
nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
