cloud-fan commented on a change in pull request #34060:
URL: https://github.com/apache/spark/pull/34060#discussion_r755769160
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -190,17 +191,32 @@ trait V2CreateTablePlan extends LogicalPlan {
def withPartitioning(rewritten: Seq[Transform]): V2CreateTablePlan
}
+trait V2CreateTablePlanX extends LogicalPlan {
+ def name: LogicalPlan
+ def partitioning: Seq[Transform]
+ def tableSchema: StructType
+
+ /**
+ * Creates a copy of this node with the new partitioning transforms. This
method is used to
+ * rewrite the partition transforms normalized according to the table schema.
+ */
+ def withPartitioning(rewritten: Seq[Transform]): V2CreateTablePlanX
+}
+
/**
* Create a new table with a v2 catalog.
*/
-case class CreateV2Table(
- catalog: TableCatalog,
- tableName: Identifier,
+case class CreateTable(
+ name: LogicalPlan,
tableSchema: StructType,
partitioning: Seq[Transform],
- properties: Map[String, String],
- ignoreIfExists: Boolean) extends LeafCommand with V2CreateTablePlan {
- override def withPartitioning(rewritten: Seq[Transform]): V2CreateTablePlan
= {
+ bucketSpec: Option[BucketSpec],
Review comment:
nit: shall we move `bucketSpec` to `TableSpec`? According to the v2
createTable API, only schema and partitioning are top-level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
