cloud-fan commented on a change in pull request #34060:
URL: https://github.com/apache/spark/pull/34060#discussion_r755786855
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -189,17 +190,35 @@ trait V2CreateTablePlan extends LogicalPlan {
def withPartitioning(rewritten: Seq[Transform]): V2CreateTablePlan
}
+trait V2CreateTablePlanX extends LogicalPlan {
Review comment:
Do we have to add this? Can we let the new `CreateTable` extends
`V2CreateTablePlan` and implement `tableName`?
```
def tableName = {
assert(name.isResolved)
name.asInstanceOf[ResolvedDBObjectName].nameParts.asIdentifier
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
