Ngone51 commented on code in PR #36162: URL: https://github.com/apache/spark/pull/36162#discussion_r885249138
########## core/src/main/scala/org/apache/spark/internal/config/package.scala: ########## @@ -2073,6 +2073,41 @@ package object config { .timeConf(TimeUnit.MILLISECONDS) .createOptional + private[spark] val SPECULATION_EFFICIENCY_ENABLE = + ConfigBuilder("spark.speculation.efficiency.enabled") + .doc("When set to true, spark will evaluate the efficiency of task processing through the " + + "stage task metrics and only need to speculate the inefficient tasks.") Review Comment: nit: could you also explain a bit more about what is an inefficient task? e.g., "A task is inefficient when its data process rate is less than the average data process rate of all successful tasks in the stage multiplied by a factor." Something like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org