Ngone51 commented on code in PR #36162:
URL: https://github.com/apache/spark/pull/36162#discussion_r885265232
##########
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala:
##########
@@ -109,6 +116,13 @@ private[spark] class TaskSetManager(
private val executorDecommissionKillInterval =
conf.get(EXECUTOR_DECOMMISSION_KILL_INTERVAL).map(TimeUnit.SECONDS.toMillis)
+ private[scheduler] val inefficientTaskCalculator =
+ if (conf.get(SPECULATION_ENABLED) &&
conf.get(SPECULATION_EFFICIENCY_ENABLE)) {
Review Comment:
With https://github.com/apache/spark/pull/36162/files#r885262650, I think we
can use `efficientTaskCalcualtionEnabled` directly.
##########
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala:
##########
@@ -797,6 +830,9 @@ private[spark] class TaskSetManager(
return
}
+ if (inefficientTaskCalculator.isDefined) {
Review Comment:
Same with https://github.com/apache/spark/pull/36162/files#r885265232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
