Ngone51 commented on code in PR #36162: URL: https://github.com/apache/spark/pull/36162#discussion_r885264474
########## core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala: ########## @@ -80,12 +82,17 @@ private[spark] class TaskSetManager( val copiesRunning = new Array[Int](numTasks) val speculationEnabled = conf.get(SPECULATION_ENABLED) + private val speculationTaskProgressMultiplier = conf.get(SPECULATION_TASK_PROGRESS_MULTIPLIER) + private val speculationTaskDurationFactor = conf.get(SPECULATION_TASK_DURATION_FACTOR) + private val speculationTaskStatsCacheInterval = conf.get(SPECULATION_TASK_STATS_CACHE_DURATION) Review Comment: Shall we rename these confs to make it be specific to the task efffecency calculation feature? e.g., replace `speculation` with `efficient`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
