Jonathancui123 commented on code in PR #36871:
URL: https://github.com/apache/spark/pull/36871#discussion_r909035305


##########
docs/sql-data-sources-csv.md:
##########
@@ -108,6 +108,12 @@ Data source options of CSV can be set via:
     <td>Infers the input schema automatically from data. It requires one extra 
pass over the data. CSV built-in functions ignore this option.</td>
     <td>read</td>
   </tr>
+  <tr>
+    <td><code>inferDate</code></td> 
+    <td>false</td>
+    <td>Whether or not to infer columns that satisfy the 
<code>dateFormat</code> option as <code>Date</code>. Requires 
<code>inferSchema</code> to be <code>true</code>. When <code>false</code>, 
columns with dates will be inferred as <code>String</code> (or as 
<code>Timestamp</code> if it fits the <code>timestampFormat</code>) Legacy date 
formats in Timestamp columns cannot be parsed with this option.</td>

Review Comment:
   This was in reference to the fact that only the non-legacy datePaser is used 
for parsing in timestamp columns - as explained in [the first comment of this 
thread](https://github.com/apache/spark/pull/36871/files#r903187641).
   
   I'll remove it. This sentence no longer makes sense since we don't support 
date inference for legacy date formats. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to