[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39654: [SHUFFLE][MINOR] Include IOException in warning log of finalizeShuffleMerge

[GitBox]

dongjoon-hyun commented on code in PR #39654:
URL: https://github.com/apache/spark/pull/39654#discussion_r1081658172


##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -848,13 +848,13 @@ public void registerExecutor(String appId, 
ExecutorShuffleInfo executorInfo) {
           = new TypeReference<Map<String, String>>(){};
         Map<String, String> metaMap = mapper.readValue(mergeDirInfo, typeRef);
         String mergeDir = metaMap.get(MERGE_DIR_KEY);
-        int attemptId = Integer.valueOf(
-          metaMap.getOrDefault(ATTEMPT_ID_KEY, 
String.valueOf(UNDEFINED_ATTEMPT_ID)));
         if (mergeDir == null) {
           throw new IllegalArgumentException(
             String.format("Failed to get the merge directory information from 
the " +
               "shuffleManagerMeta %s in executor registration message", 
shuffleManagerMeta));
         }
+        int attemptId = Integer.valueOf(
+          metaMap.getOrDefault(ATTEMPT_ID_KEY, 
String.valueOf(UNDEFINED_ATTEMPT_ID)));

Review Comment:
   This relocation is not needed for `Include IOException in warning log of 
finalzeShuffleMerge`. Please revert this relocation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org