[GitHub] [spark] tedyu commented on a diff in pull request #39654: [MINOR][SHUFFLE] Include IOException in warning log of finalizeShuffleMerge

[GitBox]

tedyu commented on code in PR #39654:
URL: https://github.com/apache/spark/pull/39654#discussion_r1081954269


##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -815,7 +815,7 @@ public MergeStatuses 
finalizeShuffleMerge(FinalizeShuffleMerge msg) {
           } catch (IOException ioe) {
             logger.warn("{} attempt {} shuffle {} shuffleMerge {}: exception 
while " +
                 "finalizing shuffle partition {}", msg.appId, 
msg.appAttemptId, msg.shuffleId,
-                msg.shuffleMergeId, partition.reduceId);
+                msg.shuffleMergeId, partition.reduceId, ioe);

Review Comment:
   @mridulm 
   If my understanding is correct, the logger would show the last parameter if 
it is an exception.
   See the following code from 
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
   ```
           } catch (Throwable t) {
             logger.warn("Error in responding RPC callback", t);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org