tedyu commented on code in PR #39654: URL: https://github.com/apache/spark/pull/39654#discussion_r1081661106
########## common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java: ########## @@ -848,13 +848,13 @@ public void registerExecutor(String appId, ExecutorShuffleInfo executorInfo) { = new TypeReference<Map<String, String>>(){}; Map<String, String> metaMap = mapper.readValue(mergeDirInfo, typeRef); String mergeDir = metaMap.get(MERGE_DIR_KEY); - int attemptId = Integer.valueOf( - metaMap.getOrDefault(ATTEMPT_ID_KEY, String.valueOf(UNDEFINED_ATTEMPT_ID))); if (mergeDir == null) { throw new IllegalArgumentException( String.format("Failed to get the merge directory information from the " + "shuffleManagerMeta %s in executor registration message", shuffleManagerMeta)); } + int attemptId = Integer.valueOf( + metaMap.getOrDefault(ATTEMPT_ID_KEY, String.valueOf(UNDEFINED_ATTEMPT_ID))); Review Comment: Reverted as requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org