cloud-fan commented on code in PR #45285: URL: https://github.com/apache/spark/pull/45285#discussion_r1504415553
########## sql/core/src/test/scala/org/apache/spark/sql/errors/QueryCompilationErrorsSuite.scala: ########## @@ -964,6 +964,35 @@ class QueryCompilationErrorsSuite "className" -> "org.apache.spark.sql.catalyst.expressions.UnsafeRow")) } + test("SPARK-47102: Collation in CollateContext when COLLATION_ENABLED is false") { + withSQLConf(SQLConf.COLLATION_ENABLED.key -> "false") { + checkError( + exception = intercept[AnalysisException] { + sql(s"select 'aaa' collate 'UNICODE_CI'") Review Comment: how about the type parsing like `CREATE TABLE t(col STRING COLLATE ...)`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org