mihailom-db commented on code in PR #45285: URL: https://github.com/apache/spark/pull/45285#discussion_r1505476279
########## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ########## @@ -32,6 +33,11 @@ import org.apache.spark.sql.types.StringType class CollationSuite extends DatasourceV2SQLBase { protected val v2Source = classOf[FakeV2ProviderWithCustomSchema].getName + protected override def beforeAll(): Unit = { + System.setProperty(IS_TESTING.key, "true") Review Comment: Actually, I have just checked, `DatasourceV2SQLBase` extends `QueryTest` and is implementing `SharedSparkSession`. `QueryTest` does not implement `beforeAll` and `SharedSparkSession` does, but without setting IS_TESTING key. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org