cloud-fan commented on code in PR #45285:
URL: https://github.com/apache/spark/pull/45285#discussion_r1505370756
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collationExpressions.scala:
##########
@@ -90,6 +100,9 @@ case class Collate(child: Expression, collationName: String)
since = "4.0.0",
group = "string_funcs")
case class Collation(child: Expression) extends UnaryExpression with
RuntimeReplaceable {
+ if (!SQLConf.get.collationEnabled) {
Review Comment:
It might be too much for a temporary config. Maybe let's add a new check
rule in `BaseSessionStateBuilder.analyzer.extendedCheckRules`, and fail if
these two expressions are found in the plan tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
