mkaravel commented on code in PR #45216: URL: https://github.com/apache/spark/pull/45216#discussion_r1505438346
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ########## @@ -559,6 +559,25 @@ case class BinaryPredicate(override val prettyName: String, left: Expression, ri } } +trait CollationCheck { Review Comment: Rename to `CollationCompatibilityCheck` maybe to make it more clear what it does? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org