cloud-fan commented on code in PR #45216:
URL: https://github.com/apache/spark/pull/45216#discussion_r1505447421
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -327,11 +329,10 @@ public UTF8String substringSQL(int pos, int length) {
/**
* Returns whether this contains `substring` or not.
*/
- public boolean contains(final UTF8String substring) {
+ public boolean containsBinary(final UTF8String substring) {
Review Comment:
similar to `equals`/`compareTo`, let's not rename existing functions for
backward compatibility, just add comments to say it's the binary version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
