cloud-fan commented on code in PR #45216: URL: https://github.com/apache/spark/pull/45216#discussion_r1505462011
########## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ########## @@ -105,6 +105,9 @@ public Collation( private static final Collation[] collationTable = new Collation[4]; private static final HashMap<String, Integer> collationNameToIdMap = new HashMap<>(); + public static final int DEFAULT_COLLATION_ID = 0; + public static final int LOWERCASE_COLLATION_ID = 1; Review Comment: got it, we can leave it for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
