cloud-fan commented on code in PR #51032:
URL: https://github.com/apache/spark/pull/51032#discussion_r2111329830


##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWriterV2Suite.scala:
##########
@@ -875,4 +875,53 @@ class DataFrameWriterV2Suite extends QueryTest with 
SharedSparkSession with Befo
       }
     }
   }
+
+  test("SPARK-52312: caching dataframe created from INSERT shouldn't 
re-execute the command") {

Review Comment:
   I'm fine with this test only. It's a unit test, and we don't need to iterate 
all v2 commands to prove the fix. Testing a common v2 command (table INSERT) is 
good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to