cloud-fan commented on code in PR #51032:
URL: https://github.com/apache/spark/pull/51032#discussion_r2113191336
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala:
##########
@@ -127,6 +127,11 @@ class CacheManager extends Logging with
AdaptiveSparkPlanHelper {
// Do nothing for StorageLevel.NONE since it will not actually cache any
data.
} else if (lookupCachedDataInternal(normalizedPlan).nonEmpty) {
logWarning("Asked to cache already cached data.")
+ } else if (unnormalizedPlan.isInstanceOf[IgnoreCachedData]) {
Review Comment:
shall we move it before the above `else if`? For `IgnoreCachedData`, we
don't even need to do a lookup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
