qiyuandong-db commented on code in PR #51032:
URL: https://github.com/apache/spark/pull/51032#discussion_r2111625379
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala:
##########
@@ -94,13 +94,20 @@ class CacheManager extends Logging with
AdaptiveSparkPlanHelper {
query: Dataset[_],
tableName: Option[String],
storageLevel: StorageLevel): Unit = {
- cacheQueryInternal(
- query.sparkSession,
- query.queryExecution.analyzed,
- query.queryExecution.normalized,
- tableName,
- storageLevel
- )
+ if (query.queryExecution.analyzed.isInstanceOf[IgnoreCachedData]) {
Review Comment:
Yeah that would be better. We have two `cacheQuery()` variants and they both
call `cacheQueryInternal()`.
Moved the check there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
